Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

day1 cleanup after the action #1055

Conversation

yevgeny-shnaidman
Copy link
Member

pull-kernel-module-image.service runs twice: once to pull all the images and reboot the node, and the second time it just checks that everyting has been pulled and exits. During the second time we want to remove the tar of the loaded and saved kernel module image, so that it won't interfere with the correct flow once the node is rebooted again

pull-kernel-module-image.service runs twice: once to pull all the images
and reboot the node, and the second time it just checks that everyting
has been pulled and exits. During the second time we want to remove
the tar of the loaded and saved kernel module image, so that it won't
interfere with the correct flow once the node is rebooted again
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for openshift-kmm ready!

Name Link
🔨 Latest commit e86dfbc
🔍 Latest deploy log https://app.netlify.com/sites/openshift-kmm/deploys/65f89784d00dc6000875fc30
😎 Deploy Preview https://deploy-preview-1055--openshift-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

openshift-ci bot commented Mar 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qbarrand
Copy link
Contributor

Don't we want to keep the tarfile so that we don't have to pull it again on next boot?

@yevgeny-shnaidman
Copy link
Member Author

Don't we want to keep the tarfile so that we don't have to pull it again on next boot?

I prefer to use imagePull "Always" policy. Currently the tar file name is always the same, so just to be sure we delete it and pull everything a new. When i get to the issue 898 and issue 920 i will probably change tar file name.
But it is still better to delete it, since it also indicates the presence of the worker image. If for some reason worker image got GCed between reboots, we want to pull it again

@qbarrand
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 237f77c into rh-ecosystem-edge:main Mar 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants