Run cargo test as part of the CI #120
Conversation
|
/test baremetalds-sno-recert-cluster-rename |
I've added some unit tests recently, but they were not run as part of our GitHub actions. This commit fixes that. Also fix some broken unit tests. The unit tests were correct but sometimes they would race with each other and fail. I added the `serial_test` crate so we can annotate the tests with `#[serial]` to ensure they don't run together (as these tests modify a global variable). Also fixed some unused var warning that seems to have only started showing up in recent versions of rust/clippy.
|
/test baremetalds-sno-recert-cluster-rename |
|
I'll add the unit test execution in Prow as well 👍 |
|
/test e2e-aws-ovn-single-node-recert-serial |
|
/test e2e-aws-ovn-single-node-recert-parallel baremetalds-sno-recert-cluster-rename |
|
/lgmt |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mresvanis, omertuc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit 7c945fa
into
rh-ecosystem-edge:main
I've added some unit tests recently, but they were not run as part of our GitHub actions. This commit that.
Also fix some broken unit tests. The unit tests were correct but sometimes they would race with each other and fail. I added the
serial_testcrate so we can annotate the tests with#[serial]to ensure they don't run together (as these tests modify a global variable).Also fixed some unused var warning that seems to have only started showing up in recent versions of rust/clippy.