Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary approvers for initial konflux setup #172

Conversation

mresvanis
Copy link
Member

@mresvanis mresvanis commented Feb 13, 2025

Add Raul and Steven temporarily to the approvers list until Konflux is setup, then we can restrict their approval privileges to specific directories.

Summary by CodeRabbit

  • Chores
    • Expanded the team’s review and approval process to enhance quality control across the project.
    • Introduced additional oversight for specialized components to further streamline updates.

Signed-off-by: Michail Resvanis <mresvani@redhat.com>
@mresvanis mresvanis requested a review from omertuc February 13, 2025 13:09
Copy link

coderabbitai bot commented Feb 13, 2025

Walkthrough

The pull request updates the repository's OWNERS file by expanding the list of authorized approvers and reviewers. Two new global approvers, fontivan and rauhersu, are added for all paths matching ".*". Additionally, the reviewer list for the Dockerfile path is updated to explicitly include rauhersu. These modifications adjust the approval settings without altering existing entries.

Changes

File Change Summary
OWNERS Added fontivan and rauhersu to the global approvers for all paths (filter: ".*") and updated the Dockerfile section to include rauhersu as a reviewer.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 18d3284 and 14d3da1.

📒 Files selected for processing (1)
  • OWNERS (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build
🔇 Additional comments (2)
OWNERS (2)

11-12: Consider time-boxing or documenting the temporary nature of global approver rights.

While adding fontivan and rauhersu as global approvers aligns with the PR objectives for initial Konflux setup, the temporary nature of these permissions should be tracked to ensure they are restricted to specific directories once the setup is complete.

Consider:

  1. Adding a TODO comment with an expected timeline
  2. Creating a follow-up issue to track the permission adjustment
  3. Documenting this temporary arrangement in the repository's documentation

Would you like me to help create a tracking issue for this?


13-15: LGTM! Well-scoped reviewer assignment.

Adding rauhersu as a reviewer specifically for the Dockerfile aligns well with the long-term plan to restrict privileges to specific directories.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@openshift-ci openshift-ci bot requested a review from tsorya February 13, 2025 13:09
Copy link

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mresvanis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@omertuc
Copy link
Member

omertuc commented Feb 13, 2025

/lgtm

@omertuc
Copy link
Member

omertuc commented Feb 13, 2025

@mresvanis
Copy link
Member Author

/verify-owners

@mresvanis
Copy link
Member Author

/override e2e-aws-ovn-single-node-recert-serial e2e-aws-ovn-single-node-recert-parallel

Copy link

openshift-ci bot commented Feb 13, 2025

@mresvanis: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-aws-ovn-single-node-recert-parallel
  • e2e-aws-ovn-single-node-recert-serial

Only the following failed contexts/checkruns were expected:

  • CodeRabbit
  • ci/prow/4.14-images
  • ci/prow/4.15-images
  • ci/prow/4.16-images
  • ci/prow/4.17-images
  • ci/prow/baremetalds-sno-recert-cluster-rename
  • ci/prow/cargo-check
  • ci/prow/cargo-clippy
  • ci/prow/cargo-test
  • ci/prow/e2e-aws-ovn-single-node-recert-parallel
  • ci/prow/e2e-aws-ovn-single-node-recert-serial
  • ci/prow/images
  • pull-ci-rh-ecosystem-edge-recert-main-4.14-images
  • pull-ci-rh-ecosystem-edge-recert-main-4.15-images
  • pull-ci-rh-ecosystem-edge-recert-main-4.16-images
  • pull-ci-rh-ecosystem-edge-recert-main-4.17-images
  • pull-ci-rh-ecosystem-edge-recert-main-baremetalds-sno-recert-cluster-rename
  • pull-ci-rh-ecosystem-edge-recert-main-cargo-check
  • pull-ci-rh-ecosystem-edge-recert-main-cargo-clippy
  • pull-ci-rh-ecosystem-edge-recert-main-cargo-test
  • pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-parallel
  • pull-ci-rh-ecosystem-edge-recert-main-e2e-aws-ovn-single-node-recert-serial
  • pull-ci-rh-ecosystem-edge-recert-main-images
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-aws-ovn-single-node-recert-serial e2e-aws-ovn-single-node-recert-parallel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mresvanis
Copy link
Member Author

/override ci/prow/e2e-aws-ovn-single-node-recert-parallel ci/prow/e2e-aws-ovn-single-node-recert-serial

Copy link

openshift-ci bot commented Feb 13, 2025

@mresvanis: Overrode contexts on behalf of mresvanis: ci/prow/e2e-aws-ovn-single-node-recert-parallel, ci/prow/e2e-aws-ovn-single-node-recert-serial

In response to this:

/override ci/prow/e2e-aws-ovn-single-node-recert-parallel ci/prow/e2e-aws-ovn-single-node-recert-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 0eb7f33 into rh-ecosystem-edge:main Feb 13, 2025
14 checks passed
@mresvanis mresvanis deleted the add-approvers-for-konflux-setup branch February 13, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants