Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test support for 5 battle configs #5914

Merged
merged 20 commits into from
Feb 9, 2025
Merged

Added test support for 5 battle configs #5914

merged 20 commits into from
Feb 9, 2025

Conversation

AsparagusEduardo
Copy link
Collaborator

Description

  • B_CRIT_CHANCE
  • B_CRIT_MULTIPLIER
  • B_PARALYSIS_SPEED
  • B_CONFUSION_SELF_DMG_CHANCE
  • B_MULTI_HIT_CHANCE

Discord contact info

AsparagusEduardo

@AlexOn1ine AlexOn1ine added the category: battle-tests Related to the automated test environment label Dec 31, 2024
@Bassoonian
Copy link
Collaborator

Marking this as draft until the requested changes are applied

@Bassoonian Bassoonian marked this pull request as draft February 7, 2025 22:46
@AsparagusEduardo AsparagusEduardo marked this pull request as ready for review February 8, 2025 22:29
@AsparagusEduardo
Copy link
Collaborator Author

My god, this was a journey and a half to get all the Gen 1 configs properly tested.
Found that Focus Energy wasn't properly changing for Gen 2, so added a config to that, and that some Gen 1 handling was not proper.

Ready for re-review!

Bassoonian
Bassoonian reviewed Feb 9, 2025
View reviewed changes
Copy link
Collaborator

@Bassoonian Bassoonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor style things, excellent work other than that!

test/battle/move_effect/dragon_cheer.c Outdated Show resolved Hide resolved
test/battle/move_effect/dragon_cheer.c Outdated Show resolved Hide resolved
@Bassoonian Bassoonian merged commit 99cb40d into rh-hideout:master Feb 9, 2025
1 check passed
@AsparagusEduardo AsparagusEduardo deleted the _RHH/pr/master/genConfigs2 branch February 9, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bassoonian Bassoonian Bassoonian approved these changes

Assignees
No one assigned
Labels
category: battle-tests Related to the automated test environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AsparagusEduardo @Bassoonian @AlexOn1ine