Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo in requests_effects #6215

Merged
merged 2 commits into from
Feb 9, 2025
Merged

Fixed typo in requests_effects #6215

merged 2 commits into from
Feb 9, 2025

Conversation

hedara90
Copy link
Collaborator

@hedara90 hedara90 commented Feb 8, 2025

Description

requests_effects was misspelled in macros.
Test before and after by adding these commands to any script.

         getobjectxy 0, CURRENT_POSITION, VAR_0x8000, VAR_0x8001                                                                                                                 
         getobjecttemplatexy 0, CURRENT_POSITION, VAR_0x8000, VAR_0x8001                                                                                                         
         getobjectcurrentxy 0, CURRENT_POSITION, VAR_0x8000, VAR_0x8001                                                                                                          
         checkobjectat 10, 10                                                                                                                                                    
         getseenmon SPECIES_SLOWPOKE
         getcaughtmon SPECIES_SLOWPOKE
         setseenmon SPECIES_SLOWPOKE               
         setcaughtmon SPECIES_SLOWPOKE                                                                                                                                           
         checkspecies SPECIES_SLOWPOKE                                                                                                                                           
         getobjectfacingdirection 0 VAR_RESULT

People who collaborated with me in this PR

Discovered by @purrfectdoodle

Discord contact info

hedara

@hedara90 hedara90 added the bugfix Bugfixes label Feb 8, 2025
Pawkkie
Pawkkie requested changes Feb 9, 2025
View reviewed changes
Copy link
Collaborator

@Pawkkie Pawkkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the comment in include/script.h that has the typo in it, on line 136? I suspect that comment might be what perpetuated this typo lol

@Pawkkie Pawkkie self-assigned this Feb 9, 2025
@hedara90
Copy link
Collaborator Author

hedara90 commented Feb 9, 2025

Review comment addressed.

@Pawkkie Pawkkie merged commit 174bc2f into rh-hideout:upcoming Feb 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pawkkie Pawkkie Pawkkie approved these changes

Assignees

@Pawkkie Pawkkie

Labels
bugfix Bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hedara90 @Pawkkie