EndTurnEffectOrder Refactor #6224
Open
+2,001
−1,713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexOn1ine
added
type: refactor
type: big feature
|
Some tests are failing |
PhallenTree
reviewed
Feb 10, 2025
|
Review comments applied! |
PhallenTree
reviewed
Feb 12, 2025
PhallenTree
reviewed
Feb 12, 2025
|
review comments addressed besides the magic room issue. will fix that one later. /Edit: all fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors EndTurnEffects according to smogons research
For consistency I've changed some scripting battlers to
gBattlerAttacker. Since all effects happen at the end of the turn there shouldn't be any mutation happen.Issue(s) that this PR fixes
Closes #5024
Fixes inaccurate Emergency Exit behavior. It is supposed to trigger on residual damage as well.
Note
Ideally this is reviewed before the release of 1.11 so we can merge it as soon as it drops.