Allow tests to work out of the box on macOS #6230
Open
+19
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I heard
make check
was broken out of the box on macOS. Looked into how it works on Linux now. Binaries in the repo? Why not...I built mGBA from the commit mentioned in the README.md I've modified. I did two builds, x86_64 and ARM64. To invoke the same builds, you can run this (subbing out the
arm64
forx86_64
for the Intel build). You must also have all the normal required dependencies installed, per usual.EDIT: I forgot to enable LTO to save a little more space. Updated the notary info as well as force-pushed an amend.
You can then make a universal (fat) binary with
lipo
per usual. I've signed this binary with my personal Apple Developer certificate under my public name. I've sent it to the apple notary service and it passed, so it should pass gatekeeper on all macOS systems.I also modified the hydra sources to not use the
stdbuf
hack, which allows formake check
to work in a Rosetta shell on ARM Macs.The final, checked-in binary for macOS is 2.9 MB. I've done all I can to make it as small as possible.
Images
Things to note in the release changelog:
make check
may need to confirm with an OS dialog they're willing to openmgba-rom-test-mac
when run for the first time.Discord contact info
@luigi___