Add support for creating LUKS HW-OPAL devices #5826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtechtrefny
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
Hello @vojtechtrefny! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-08-21 16:45:01 UTC |
vojtechtrefny
force-pushed
the
master_luks-opal
branch
from
09c1e8b to
14e96d3
Compare
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
Marking as blocked for now: libblockdev (storaged-project/libblockdev#1047), blivet (storaged-project/blivet#1266) and pykickstart (pykickstart/pykickstart#502) support need to merged first and we'll also need to coordinate the releases in Fedora. |
vojtechtrefny
force-pushed
the
master_luks-opal
branch
from
14e96d3 to
035c9c3
Compare
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
The blivet and libblockdev support is now merged and making its way to Fedora. |
vojtechtrefny
force-pushed
the
master_luks-opal
branch
from
035c9c3 to
66a3ed8
Compare
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
vojtechtrefny
force-pushed
the
master_luks-opal
branch
from
66a3ed8 to
472f8bf
Compare
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype smoke |
|
/kickstart-test --testtype storage |
|
Removing the blocked label, all the dependencies are now available in the latest F41 compose (Fedora-41-20240820.n.0). |
rvykydal
reviewed
Aug 21, 2024
KKoukiou
approved these changes
Aug 21, 2024
vojtechtrefny
force-pushed
the
master_luks-opal
branch
from
472f8bf to
907936e
Compare
vojtechtrefny
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
/kickstart-test --testtype smoke |
This adds support for creating encrypted devices using the OPAL self-encrypting drives. Anaconda only needs to make sure to pass the OPAL administrator passphrase to Blivet when creating the LUKS device, everything else will be taken care by either Blivet or pykickstart -- whether a "normal" or OPAL LUKS device will be created is controlled by the "--luks-version" kickstart option specified by the user which is passed "as is" to Blivet.
vojtechtrefny
force-pushed
the
master_luks-opal
branch
from
907936e to
989f6d0
Compare
vojtechtrefny
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
/kickstart-test --testtype smoke |
KKoukiou
reviewed
Aug 21, 2024
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for creating encrypted devices using the OPAL self-encrypting drives. Anaconda only needs to make sure to pass the OPAL administrator passphrase to Blivet when creating the LUKS device, everything else will be taken care by either Blivet or pykickstart -- whether a "normal" or OPAL LUKS device will be created is controlled by the "--luks-version" kickstart option specified by the user which is passed "as is" to Blivet.