Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dracut: add static linkage to internal functions #6203

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

KKoukiou
Copy link
Contributor

Added the static keyword to functions that are not used outside their respective source files to limit their linkage and prevent potential symbol conflicts.

@github-actions github-actions bot added the f43 label Feb 24, 2025
Copy link
Contributor

@elkoniu elkoniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Added the `static` keyword to functions that are not used outside their
respective source files to limit their linkage and prevent potential
symbol conflicts.
Removed the local definition of `headerGetString` in rpmutils.c to avoid
conflicts with the existing declaration in the RPM library headers. The
code now uses the library-provided function from <rpm/header.h>.
Copy link
Contributor

@elkoniu elkoniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KKoukiou KKoukiou requested a review from jkonecny12 February 24, 2025 16:08
@KKoukiou
Copy link
Contributor Author

/kickstart-tests --testtype smoke

Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. :)

@KKoukiou KKoukiou merged commit 6702abe into rhinstaller:main Feb 24, 2025
17 checks passed
@KKoukiou KKoukiou deleted the static-linkage branch February 24, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants