-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dracut: add static linkage to internal functions #6203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
3965e80
to
4b9a8fc
Compare
Added the `static` keyword to functions that are not used outside their respective source files to limit their linkage and prevent potential symbol conflicts.
4b9a8fc
to
fd88e93
Compare
Removed the local definition of `headerGetString` in rpmutils.c to avoid conflicts with the existing declaration in the RPM library headers. The code now uses the library-provided function from <rpm/header.h>.
fd88e93
to
3f4e041
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/kickstart-tests --testtype smoke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. :)
Added the
static
keyword to functions that are not used outside their respective source files to limit their linkage and prevent potential symbol conflicts.