Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files for Strong APA #12

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add files for Strong APA #12

wants to merge 8 commits into from

Conversation

richidubey
Copy link
Owner

No description provided.

* This assert makes sure that there always exist an element in the
* Queue when we start the queue traversal.
*/
_Assert( !_Processor_mask_Is_zero( &strong_node->Affinity ) );
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be a bug for that to happen, or is it possible an application somehow specifies this behavior?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the paper, it should be acceptable. The node(Tnew) would remain unassigned. So I have made some changes, please check the latest commit. These changes now allow for having a node with empty affinity set. But, having a node with empty affinity set does not make sense, since at the end of Enqueue function, if the newly arrived node is not scheduled, it asks for help - which checks for the lowest scheduled directly reachable node - which cannot be checked if the node has an empty affinity set. Thus it does not matter whether we have an assert here or not. I have removed the assert for now.

@richidubey richidubey force-pushed the 2ndWeekMar-Strong-APA branch from 1acb7cd to eacf53f Compare March 22, 2021 06:07
@richidubey richidubey force-pushed the 2ndWeekMar-Strong-APA branch from ddc43b1 to 00427da Compare March 24, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants