Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image size for better performance #13 #14

Merged
merged 1 commit into from
Jan 29, 2025
Merged

fix: image size for better performance #13 #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions blog/templates/blog/blog.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ <h2 class="subtitle">Berikut adalah daftar artikel blog yang tersedia.</h2>
{% for blog in blogs %}
<div class="column is-half-tablet is-half-desktop is-one-third-widescreen">
<div class="card">
{% if blog.thumbnail %}
{% if blog.image %}
<div class="card-image">
<figure class="image is-1by1">
<img src="{% static blog.thumbnail %}" alt="{{ blog.title }}" loading="lazy" />
<figure class="image is-16by9">
<img src="{% static blog.image %}" alt="{{ blog.title }}" loading="lazy" height="360" width="640" />
</figure>
</div>
{% endif %}
Expand All @@ -43,7 +43,7 @@ <h2 class="subtitle">Berikut adalah daftar artikel blog yang tersedia.</h2>
<div class="media">
<div class="media-left">
<figure class="image is-48x48">
<img src="{% static 'icon-32x32.png' %}" alt="ridwaanhall second icon" />
<img src="{% static 'icon-192x192.png' %}" alt="ridwaanhall second icon" width="48" height="48" />
</figure>
</div>
<div class="media-content">
Expand Down
1 change: 0 additions & 1 deletion blog/templates/blog/blog_detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
{% block title %}{{ blog.title }} - Lumina Blog{% endblock %}

{% block content %}

<section class="section">
<div class="columns">
<div class="column is-8">
Expand Down
6 changes: 3 additions & 3 deletions templates/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
<div class="content">
<div class="columns is-vcentered is-multiline">
<div class="column is-12-mobile is-6-tablet">
<p class="has-text-grey">© {% now "Y" %} Lumina</p>
<p>© {% now "Y" %} Lumina</p>
<div class="is-inline-flex mt-2">
<a href="{% url 'terms' %}" class="has-text-grey mr-4 {% if request.resolver_match.url_name == 'terms' %}is-underlined is-italic{% endif %}">Ketentuan</a>
<a href="{% url 'about' %}" class="has-text-grey {% if request.resolver_match.url_name == 'about' %}is-underlined is-italic{% endif %}">Tentang</a>
<a href="{% url 'terms' %}" class="mr-4 {% if request.resolver_match.url_name == 'terms' %}is-underlined is-italic{% endif %}">Ketentuan</a>
<a href="{% url 'about' %}" class="{% if request.resolver_match.url_name == 'about' %}is-underlined is-italic{% endif %}">Tentang</a>
</div>
</div>
<div class="column is-12-mobile is-6-tablet has-text-right-tablet">
Expand Down
2 changes: 1 addition & 1 deletion templates/navbar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<div class="container">
<div class="navbar-brand">
<a class="navbar-item" href="{% url 'lumina-app' %}">
<img src="{% static 'icon-32x32.png' %}" alt="Kucing Legend" width="28" height="28" />
<img src="{% static 'icon-192x192.png' %}" alt="Kucing Legend" width="28" height="28" />
<strong class="ml-2">Lumina</strong>
</a>

Expand Down