Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr check action 오류 수정 #4

Merged
merged 6 commits into from
Nov 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions .github/workflows/action-check-pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ on:
pull_request:
types: [opened, edited, synchronize, reopened, ready_for_review]

permissions:
pull-requests: write # PR에 대한 쓰기 권한 부여
issues: write # 이슈에 대한 쓰기 권한 부여 (라벨 추가를 위한)

jobs:
check:
runs-on: ubuntu-latest
Expand All @@ -17,27 +21,27 @@ jobs:
with:
node-version: '18'
- name: Install pnpm
run: npm install -g pnpm # pnpm을 전역으로 설치
run: npm install -g pnpm # pnpm을 전역으로 설치

- name: Install Dependencies
run: pnpm install # pnpm을 사용하여 의존성 설치
run: pnpm install # pnpm을 사용하여 의존성 설치

- name: Run Lint
run: pnpm lint # 린트 실행
run: pnpm lint # 린트 실행

- name: Run Prettier
run: pnpm format --check # 프리티어 체크
run: pnpm format --check # 프리티어 체크

- name: Build
run: pnpm build # 빌드 실행
- name: Build # 머지하려는 브랜치가 main 브랜치이면 build:prod, dev 브랜치이면 build:dev
run: pnpm build:${{ github.event.pull_request.base.ref == 'main' && 'prod' || 'dev' }}

label:
runs-on: ubuntu-latest
needs: check # check 작업이 완료된 후 실행
needs: check # check 작업이 완료된 후 실행

steps:
- name: Add Labels
if: github.event.pull_request.draft == false # 드래프트가 아닐 경우에만 실행
uses: actions/add-labels@v1
if: github.event.pull_request.draft == false # 드래프트가 아닐 경우에만 실행
uses: actions-ecosystem/action-add-labels@v1 # 라벨 추가 액션
with:
labels: ${{ github.event.pull_request.base.ref == 'dev' && 'dev' || github.event.pull_request.base.ref == 'main' && 'main'}} # dev로 머지 시 dev 라벨, main으로 머지 시 main 라벨
labels: ${{ github.event.pull_request.base.ref == 'dev' && 'dev' || github.event.pull_request.base.ref == 'main' && 'main'}} # dev로 머지 시 dev 라벨, main으로 머지 시 main 라벨
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
node_modules
.prettierrc
build
7 changes: 7 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"semi": true,
"singleQuote": true,
"trailingComma": "es5",
"tabWidth": 2,
"printWidth": 120
}
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
"dev": "cross-env NODE_ENV=development webpack serve --open",
"build:dev": "cross-env NODE_ENV=development webpack",
"build:prod": "cross-env NODE_ENV=production webpack",
"start:dev": "npm run build:dev && node dist/bundle.js",
"start:prod": "npm run build:prod && node dist/bundle.js"
"start:dev": "npm run build:dev && serve -s build",
"start:prod": "npm run build:prod && serve -s build"
},
"keywords": [],
"author": "",
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion src/index.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react';
import ReactDOM from 'react-dom/client';
import App from 'App';
import App from '@/App';

const root = ReactDOM.createRoot(document.getElementById('root')!);
root.render(
Expand Down
9 changes: 6 additions & 3 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,19 @@ module.exports = {
entry: './src/index.tsx',
output: {
filename: 'bundle.js',
path: path.resolve(__dirname, 'dist'),
path: path.resolve(__dirname, 'build'),
clean: true, // 이전 빌드 파일 삭제
},
resolve: {
alias: {
'@': path.resolve(__dirname, 'src'),
},
extensions: ['.ts', '.tsx', '.js', '.jsx'], // 처리할 파일 확장자
},
module: {
rules: [
{
test: /\.tsx?$/, // 타입스크립트 파일 처리
test: /\.tsx?$/, // 타입스크립트 파일 처리 ts, tsx
use: 'ts-loader',
exclude: /node_modules/,
},
Expand All @@ -25,7 +28,7 @@ module.exports = {
mode: process.env.NODE_ENV || 'development',
plugins: [
new HtmlWebpackPlugin({
template: './index.html', // 기본 HTML 템플릿
template: './public/index.html', // 기본 HTML 템플릿
}),
],
devtool: process.env.NODE_ENV === 'development' ? 'source-map' : false, // 소스 맵
Expand Down
Loading