Log job retries as warnings instead of errors (#743)

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- Errors returned from retryable jobs are now logged with warning logs instead of error logs. Error logs are still used for jobs that error after reaching `max_attempts`. [PR #743](https://github.com/riverqueue/river/pull/743).
+
 ### Fixed
 
 - `riverdatabasesql` driver: properly handle `nil` values in `bytea[]` inputs. This fixes the driver's handling of empty unique keys on insert for non-unique jobs with the newer unique jobs implementation. [PR #739](https://github.com/riverqueue/river/pull/739).

example_graceful_shutdown_test.go

@@ -169,5 +169,5 @@ func Example_gracefulShutdown() {
 	// Received SIGINT/SIGTERM; initiating soft stop (try to wait for jobs to finish)
 	// Received SIGINT/SIGTERM again; initiating hard stop (cancel everything)
 	// Job cancelled
-	// jobExecutor: Job errored
+	// jobExecutor: Job errored; retrying
 }

job_executor.go

@@ -336,7 +336,11 @@ func (e *jobExecutor) reportError(ctx context.Context, res *jobExecutorResult) {
 		cancelJob = true
 		e.Logger.DebugContext(ctx, e.Name+": Job cancelled explicitly", logAttrs...)
 	case res.Err != nil:
-		e.Logger.ErrorContext(ctx, e.Name+": Job errored", logAttrs...)
+		if e.JobRow.Attempt >= e.JobRow.MaxAttempts {
+			e.Logger.ErrorContext(ctx, e.Name+": Job errored", logAttrs...)
+		} else {
+			e.Logger.WarnContext(ctx, e.Name+": Job errored; retrying", logAttrs...)
+		}
 	case res.PanicVal != nil:
 		e.Logger.ErrorContext(ctx, e.Name+": Job panicked", logAttrs...)
 	}