Move to math/rand/v2 and away from internal service rand
#253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
force-pushed
the
brandur-rand-v2
branch
from
1549e12 to
49c58ea
Compare
bgentry
approved these changes
Dec 16, 2024
handler.go
Outdated
Comment on lines
132
to
136
| // TODO: Switch to baseservice.NewArchetype when available. | ||
| archetype: &baseservice.Archetype{ | ||
| Logger: opts.Logger, | ||
| Rand: randutil.NewCryptoSeededConcurrentSafeRand(), | ||
| Time: &baseservice.UnStubbableTimeGenerator{}, | ||
| }, |
There was a problem hiding this comment.
Want to take care of this TODO too while in here? I think this does it:
- // TODO: Switch to baseservice.NewArchetype when available.
- archetype: &baseservice.Archetype{
- Logger: opts.Logger,
- Rand: randutil.NewCryptoSeededConcurrentSafeRand(),
- Time: &baseservice.UnStubbableTimeGenerator{},
- },
- client: opts.Client,
- dbPool: opts.DB,
- logger: opts.Logger,
+ archetype: baseservice.NewArchetype(opts.Logger),
+ client: opts.Client,
+ dbPool: opts.DB,
+ logger: opts.Logger,There was a problem hiding this comment.
Yeah, good call. Done.
Also added changelog.
brandur
force-pushed
the
brandur-rand-v2
branch
from
49c58ea to
1fa1d18
Compare
Follows up [1] to move to `math/rand/v2`, which automatically seeds itself, and away from the internal random source that came in with `baseservice.Archetype`. [1] riverqueue/river#691
brandur
force-pushed
the
brandur-rand-v2
branch
from
1fa1d18 to
3defb39
Compare
Merged
brandur
added a commit
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up [1] to move to
math/rand/v2, which automatically seedsitself, and away from the internal random source that came in with
baseservice.Archetype.[1] riverqueue/river#691