Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to match SHA1 cutoff date for key signatures. #2180

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Update tests to match SHA1 cutoff date for key signatures. #2180

merged 1 commit into from
Jan 22, 2024

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Jan 19, 2024 •
edited
Loading

Fixes #1961
Fixes #2182

@codecov Codecov
Copy link

codecov bot commented Jan 19, 2024 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (2cf8fd2) 77.07% compared to head (eb1f10b) 77.08%.
Report is 7 commits behind head on main.

Files Patch % Lines
src/tests/ffi-enc.cpp 0.00% 4 Missing ⚠️
src/lib/crypto/backend_version.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2180      +/-   ##
==========================================
+ Coverage   77.07%   77.08%   +0.01%     
==========================================
  Files         194      194              
  Lines       37257    37262       +5     
==========================================
+ Hits        28715    28724       +9     
+ Misses       8542     8538       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ni4 ni4 force-pushed the ni4-1961-fix-sha1-deprecation-tests branch from f224704 to 01ad985 Compare January 19, 2024 15:29
@ni4 ni4 marked this pull request as ready for review January 20, 2024 09:32
@ni4 ni4 mentioned this pull request Jan 20, 2024
Closed
@ni4
Copy link
Contributor Author

ni4 commented Jan 20, 2024

Not sure why codecov is not happy here.

maxirmx
maxirmx requested changes Jan 20, 2024
View reviewed changes
Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a call to encrypt_decrypt commented test_generate_elgamal_key1024_in_gpg_and_encrypt(self) can be removed.

I did not try to understabd the logic, just a formal note.

@ni4 ni4 force-pushed the ni4-1961-fix-sha1-deprecation-tests branch from 01ad985 to eb1f10b Compare January 22, 2024 10:41
@ni4 ni4 requested a review from maxirmx January 22, 2024 10:42
@ni4
Copy link
Contributor Author

ni4 commented Jan 22, 2024

Let's merge it as codecov diff report somehow glitched.

@ni4 ni4 merged commit 07745e2 into main Jan 22, 2024
114 of 115 checks passed
@ni4 ni4 deleted the ni4-1961-fix-sha1-deprecation-tests branch January 22, 2024 12:35
@ni4 ni4 mentioned this pull request Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldtse ronaldtse ronaldtse approved these changes

@maxirmx maxirmx maxirmx approved these changes

@antonsviridenko antonsviridenko antonsviridenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_key_add_userid and test_ffi_security_profile failure Tests fail after 2024-01-19
4 participants
@ni4 @ronaldtse @maxirmx @antonsviridenko