libsexpp updated to 0.8.8 #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2242 +/- ##
==========================================
- Coverage 83.58% 83.58% -0.01%
==========================================
Files 107 107
Lines 23174 23167 -7
==========================================
- Hits 19371 19364 -7
Misses 3803 3803 ☔ View full report in Codecov by Sentry. |
maxirmx
force-pushed
the
maxirmx-libsexpp-update
branch
from
854201a to
d643129
Compare
maxirmx
force-pushed
the
maxirmx-libsexpp-update
branch
from
d643129 to
0d4c203
Compare
maxirmx
force-pushed
the
maxirmx-libsexpp-update
branch
2 times, most recently
from
ae69bf5 to
8fe8b89
Compare
maxirmx
force-pushed
the
maxirmx-libsexpp-update
branch
2 times, most recently
from
cb0b04f to
c02e22c
Compare
antonsviridenko
approved these changes
Jun 17, 2024
|
lgtm. There is still https://github.com/rnpgp/rnp/blame/main/src/lib/types.h#L75 I guess one needs to include the |
maxirmx
force-pushed
the
maxirmx-libsexpp-update
branch
4 times, most recently
from
133ebf8 to
817caea
Compare
|
@maxirmx Yeah, like a bunch of other PRs :) Waiting for the second approval cc @ronaldtse |
|
@maxirmx Now PR with CI fixes is merged, could you please rebase this? Or I can do that as well. |
maxirmx
force-pushed
the
maxirmx-libsexpp-update
branch
from
817caea to
e0790a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2241