Merge pull request #42 from vitri-ent/vitri/image-0.25 #180
clippy
5 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 5 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.76.0 (07dca489a 2024-02-04)
- cargo 1.76.0 (c84b36747 2024-01-18)
- clippy 0.1.76 (07dca48 2024-02-04)
Annotations
Check warning on line 110 in src/features/image.rs
github-actions / clippy
deref on an immutable reference
warning: deref on an immutable reference
--> src/features/image.rs:110:2
|
110 | &*buffer
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
= note: `#[warn(clippy::borrow_deref_ref)]` on by default
help: if you would like to reborrow, try removing `&*`
|
110 | buffer
|
help: if you would like to deref, try using `&**`
|
110 | &**buffer
|
Check warning on line 297 in src/backend/window.rs
github-actions / clippy
use of deprecated method `indexmap::IndexMap::<K, V, S>::remove`: `remove` disrupts the map order -- use `swap_remove` or `shift_remove` for explicit behavior.
warning: use of deprecated method `indexmap::IndexMap::<K, V, S>::remove`: `remove` disrupts the map order -- use `swap_remove` or `shift_remove` for explicit behavior.
--> src/backend/window.rs:297:44
|
297 | let removed = self.window_mut().overlays.remove(name.as_ref()).is_some();
| ^^^^^^
|
= note: `#[warn(deprecated)]` on by default
Check warning on line 124 in src/lib.rs
github-actions / clippy
private item shadows public glob re-export
warning: private item shadows public glob re-export
--> src/lib.rs:124:1
|
124 | mod image;
| ^^^^^^^^^^
|
note: the name `image` in the type namespace is supposed to be publicly re-exported here
--> src/lib.rs:130:9
|
130 | pub use self::features::*;
| ^^^^^^^^^^^^^^^^^
note: but the private item here shadows it
--> src/lib.rs:124:1
|
124 | mod image;
| ^^^^^^^^^^
= note: `#[warn(hidden_glob_reexports)]` on by default
Check warning on line 11 in src/backend/util/mod.rs
github-actions / clippy
unused import: `map_buffer::map_buffer_mut`
warning: unused import: `map_buffer::map_buffer_mut`
--> src/backend/util/mod.rs:11:9
|
11 | pub use map_buffer::map_buffer_mut;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 7 in src/backend/util/mod.rs
github-actions / clippy
unused import: `buffer::create_buffer_with_value`
warning: unused import: `buffer::create_buffer_with_value`
--> src/backend/util/mod.rs:7:9
|
7 | pub use buffer::create_buffer_with_value;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default