Restore compatibility with C++17 in public headers #3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
temporarily deployed
to
code-analysis
GitHub Actions
Inactive
traversaro
had a problem deploying
to
code-analysis
GitHub Actions
Failure
traversaro
had a problem deploying
to
code-analysis
GitHub Actions
Failure
Nicogene
approved these changes
Feb 20, 2025
|
We validated that this version permits to compile fine all the superbuild in robotology/robotology-superbuild#1799 . |
randaz81
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in a meeting with @randaz81, @elandini84 and @Nicogene, in the short term to avoid downstream problems it is convenient to keep at least the header of YARP compatible with C++ 17 .
This is not a long term decision, and in future the minimum C++ version required to compile headers could be increased again.