Skip to content

Commit

Permalink
setup.py: install fonttools with '[unicode]' extra to install unicode…
Browse files Browse the repository at this point in the history 
…data2 backport

so that defcon.unicodeTools are up-to-date and use Unicode Character Database 11.0
  • Loading branch information
@anthrotype
anthrotype committed Oct 29, 2018
1 parent be5e1b8 commit 8469ee3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion setup.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ def run(self):
'pytest>=3.0.3',
],
install_requires=[
"fonttools[ufo] >= 3.31.0",
"fonttools[ufo,unicode] >= 3.31.0",
],
extras_require={
'pens': ["fontPens>=0.1.0"],
Expand Down

5 comments on commit 8469ee3

@benkiel
Copy link
Member

@benkiel benkiel commented on 8469ee3 Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anthrotype Just asking — I remember discussion about the differences of unicodedata, mostly with the closing/opening bits — did this get resolved, or will this now produce a different result?

@anthrotype
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, I can't remember actually...

@benkiel
Copy link
Member

@benkiel benkiel commented on 8469ee3 Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, there was this: #189. Looking more for the thing I'm vaguely remembering (it may have been in another tool completely...)

@benkiel
Copy link
Member

@benkiel benkiel commented on 8469ee3 Nov 1, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it was this: #140 (comment)

Looking to see if we've actually lost this bit: #140 (comment)

From the look of it, it's not tested right now.

@benkiel
Copy link
Member

@benkiel benkiel commented on 8469ee3 Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, the right stuff is still there, we're all good. Opening a separate issue about the /Tools

Please sign in to comment.