v1: use deep copy, as per #758 in copyData (#764)

* use deep copy, as per #758 in copyData * Add test * try first of Tal options
robotools · Nov 8, 2024 · 5632c1b · 5632c1b
1 parent 19f9ac6
commit 5632c1b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/Lib/fontParts/base/base.py b/Lib/fontParts/base/base.py
@@ -335,7 +335,7 @@ def copyData(self: BaseObjectType, source: BaseObjectType) -> None:
             if isinstance(selfValue, BaseObject):
                 selfValue.copyData(sourceValue)
             else:
-                setattr(self, attr, sourceValue)
+                setattr(self, attr, deepcopy(sourceValue))
 
     # ----------
     # Exceptions

diff --git a/Lib/fontParts/test/test_info.py b/Lib/fontParts/test/test_info.py
@@ -95,6 +95,18 @@ def test_update(self):
         self.assertEqual(info1.familyName, "test2")
         self.assertEqual(info1.unitsPerEm, 2000)
 
+    # ----
+    # Copy
+    # ----
+    def test_copy(self):
+        info1 = self.getInfo_generic()
+        info1.postscriptBlueValues = [-10, 0, 50, 60]
+
+        info2 = info1.copy()
+        info2.postscriptBlueValues[0] = -2
+
+        self.assertNotEqual(info1.postscriptBlueValues, info2.postscriptBlueValues)
+
     # -------------
     # Interpolation
     # -------------