Resolve mypy errors. (#794)

* Resolve `mypy` errors. --------- Co-authored-by: knutnergaard <knutnergaard@users.noreply.github.com>
robotools · Nov 29, 2024 · e02cd58 · e02cd58
1 parent 0bb02b4
commit e02cd58
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 16 deletions.
diff --git a/Lib/fontParts/base/bPoint.py b/Lib/fontParts/base/bPoint.py
@@ -17,6 +17,7 @@
     PairType,
     PairCollectionType,
     SextupleCollectionType,
+    IntFloatType,
 )
 
 if TYPE_CHECKING:

diff --git a/Lib/fontParts/base/contour.py b/Lib/fontParts/base/contour.py
@@ -476,14 +476,17 @@ def _transformBy(
 
     compatibilityReporterClass = ContourCompatibilityReporter
 
-    def isCompatible(self, other: BaseContour) -> Tuple[bool, str]:
+    def isCompatible(
+        self, other: BaseContour
+    ) -> Tuple[bool, ContourCompatibilityReporter]:
         """Evaluate interpolation compatibility with another contour.
 
         :param other: The other :class:`BaseContour` instance to check
             compatibility with.
         :return: A :class:`tuple` where the first element is a :class:`bool`
-            indicating compatibility, and the second element is a :class:`str`
-            of compatibility notes.
+            indicating compatibility, and the second element is
+            a :class:`fontParts.base.compatibility.ContourCompatibilityReporter`
+            instance.
 
         Example::
 

diff --git a/Lib/fontParts/base/font.py b/Lib/fontParts/base/font.py
@@ -2058,7 +2058,7 @@ def _interpolate(
 
     compatibilityReporterClass = FontCompatibilityReporter
 
-    def isCompatible(self, other: BaseFont) -> Tuple[bool, str]:
+    def isCompatible(self, other: BaseFont) -> Tuple[bool, FontCompatibilityReporter]:
         """Evaluate interpolation compatibility with another font.
 
         This method will return a :class:`bool` indicating if the font is
@@ -2068,8 +2068,8 @@ def isCompatible(self, other: BaseFont) -> Tuple[bool, str]:
         :param other: The other :class:`BaseFont` instance to check
             compatibility with.
         :return: A :class:`tuple` where the first element is a :class:`bool`
-            indicating compatibility, and the second element is a :class:`str`
-            of compatibility notes.
+            indicating compatibility, and the second element is
+            a :class:`fontParts.base.compatibility.FontCompatibilityReporter` instance.
 
         Example::
 

diff --git a/Lib/fontParts/base/glyph.py b/Lib/fontParts/base/glyph.py
@@ -2795,14 +2795,15 @@ def _checkPairs(
                 reporter.warning = True
             reporterObject.append(compatibility)
 
-    def isCompatible(self, other: BaseGlyph) -> Tuple[bool, str]:
+    def isCompatible(self, other: BaseGlyph) -> Tuple[bool, GlyphCompatibilityReporter]:
         """Evaluate interpolation compatibility with another glyph.
 
         :param other: The other :class:`BaseGlyph` instance to check
             compatibility with.
         :return: A :class:`tuple` where the first element is a :class:`bool`
-            indicating compatibility, and the second element is a :class:`str`
-            of compatibility notes.
+            indicating compatibility, and the second element is
+            a :class:`fontParts.base.compatibility.GlyphCompatibilityReporter`
+            instance.
 
         """
         return super(BaseGlyph, self).isCompatible(other, BaseGlyph)

diff --git a/Lib/fontParts/base/layer.py b/Lib/fontParts/base/layer.py
@@ -1075,14 +1075,15 @@ def _interpolate(
 
     compatibilityReporterClass = LayerCompatibilityReporter
 
-    def isCompatible(self, other: BaseLayer) -> tuple[bool, str]:
+    def isCompatible(self, other: BaseLayer) -> Tuple[bool, LayerCompatibilityReporter]:
         """Evaluate interpolation compatibility with another layer.
 
         :param other: The other :class:`BaseLayer` instance to check
             compatibility with.
         :return: A :class:`tuple` where the first element is a :class:`bool`
-            indicating compatibility, and the second element is a :class:`str`
-            of compatibility notes.
+            indicating compatibility, and the second element is
+            a :class:`fontParts.base.compatibility.LayerCompatibilityReporter`
+            instance.
 
         Example::
 
@@ -1098,7 +1099,7 @@ def isCompatible(self, other: BaseLayer) -> tuple[bool, str]:
         return super(BaseLayer, self).isCompatible(other, BaseLayer)
 
     def _isCompatible(
-        self, other: BaseLib, reporter: LayerCompatibilityReporter
+        self, other: BaseLayer, reporter: LayerCompatibilityReporter
     ) -> None:
         """Evaluate interpolation compatibility with another native layer.
 

diff --git a/Lib/fontParts/base/segment.py b/Lib/fontParts/base/segment.py
@@ -613,7 +613,9 @@ def _transformBy(self, matrix: SextupleCollectionType[IntFloatType], **kwargs: A
 
     compatibilityReporterClass = SegmentCompatibilityReporter
 
-    def isCompatible(self, other: BaseSegment) -> Tuple[bool, str]:
+    def isCompatible(
+        self, other: BaseSegment
+    ) -> Tuple[bool, SegmentCompatibilityReporter]:
         """Evaluate interpolation compatibility with another segment.
 
         This method will return a :class:`bool` indicating if the segment is
@@ -623,8 +625,9 @@ def isCompatible(self, other: BaseSegment) -> Tuple[bool, str]:
         :param other: The other :class:`BaseSegment` instance to check
             compatibility with.
         :return: A :class:`tuple` where the first element is a :class:`bool`
-            indicating compatibility, and the second element is a :class:`str`
-            of compatibility notes.
+            indicating compatibility, and the second element is
+            a :class:`fontParts.base.compatibility.SegmentCompatibilityReporter`
+            instance.
 
         Example::