Revise annotations.py with new generic container types.
#755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add .. autoclass:: BasePoint to Reference section.
Correct last commit to autoclass:: BasePoint
Add intersphinx mapping to python 3 inventory.
Correct import error.
This reverts commit e7152b0. i#
…methods in base/layer.py and fontshell/layer.py to return mappings to tuple. - Update base/layer.py with doc revisions and type annotations. - Update layer.rst accordingly. - Fix link to fontParts.world in various .rst files.
…ion." This reverts commit fa52b70.
This reverts commit 3d67a1d.
|
@benkiel Excuse all the commits. I've been having (serious) merge troubles, but now the branch is finally down to the actual files I intended to change, and I'm a bit wiser with regard to working with git in general. I'm happy to repost this PR with a clean history if necessary. |
|
@benkiel I've revised the annotated modules, as well as improved the |
|
@knutnergaard great. I'll review: is this PR ready for that? |
|
@benkiel, yes please do. |
benkiel
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #751, this version of the annotations module includes more generic container types which may be used instead of the current font-specific type aliases. This will minimise the need for type-related imports and simplify the annotation process, while making types less font-specific.
This revision will require a total overhaul of the typed modules in the
v1branch.