Fix copyData based on #758 #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@typesupply seems like the first of your two options works. (tried the second, safer, option in the v1 branch, failed this test) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #765 +/- ##
=======================================
Coverage 78.30% 78.30%
=======================================
Files 41 41
Lines 6094 6094
Branches 1017 976 -41
=======================================
Hits 4772 4772
Misses 1116 1116
Partials 206 206
|
benkiel
added a commit
that referenced
this pull request
Nov 20, 2024
* Update fonttools from 4.53.1 to 4.54.1 (#746) * Update base.py (#750) * Fix copyData based on #758 (#765) * add test based on #758 * use deepcopy in copyData * Update fonttools from 4.54.1 to 4.55.0 (#771) * Stop testing 3.8, start testing 3.12, 3.13 * Format fixes by ruff --------- Co-authored-by: pyup.io bot <github-bot@pyup.io> Co-authored-by: benkiel <benkiel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.