Revise Color.
#768
Merged
Revise Color.
#768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor code according to robotools#767. - Add type annotations. - Improve documentation.
Deleted unintentional additions.
|
@benkiel Not sure why this fails the tests. Does the class have to override Also, I'm not sure why the PR insists on changing |
benkiel
approved these changes
Nov 13, 2024
Lib/fontParts/base/color.py
Outdated
| ) | ||
|
|
||
|
|
||
| class Color(BaseObject, tuple): |
There was a problem hiding this comment.
Think that tests are failing because Color is extending BaseObject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Color#767.