Add support for pathlib.Path to normalizeFilePath.
#784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add type annotation. - Add/improve documentation. - changed `BaseSegments.segments` to return `tuple` instead of `list`.
knutnergaard
changed the title
normalizeFilePath.pathlib.Path to normalizeFilePath.
Add `pathlib.Path` to exception documentation in `normalizeFilePath`.
- broadened scope of `Path.resolve` for improved robustness - document implicit exception. - improved error message. - corrected typo in docstring.
|
@benkiel A couple tests fail after the latest commit, but I think the improved file path robustness is worth changing |
|
@knutnergaard will look at tests (and add some for path lib) |
|
I am going to merge this and then fix the tests in a new PR (it's easier) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.