Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate and document groups.py. #793

Merged
merged 10 commits into from
Dec 3, 2024
Merged

Annotate and document groups.py. #793

merged 10 commits into from
Dec 3, 2024

Conversation

knutnergaard
Copy link
Contributor

No description provided.

@knutnergaard knutnergaard changed the base branch from master to v1 November 29, 2024 11:22
@knutnergaard knutnergaard marked this pull request as ready for review November 30, 2024 10:46
@knutnergaard
Copy link
Contributor Author

The method name findGlyph seems unclear to me considering what the method actually does. I would suggest changing it, if possible, to something like findGroups or findGlyphGroups.

benkiel
benkiel requested changes Dec 3, 2024
View reviewed changes
@benkiel
Copy link
Member

benkiel commented Dec 3, 2024

As for findGlyph, that would break too many things to change, prefer to leave as is. @typesupply do you have a differing opinion?

@typesupply
Copy link
Member

Yes. Don't change the findGlyph method name.

@benkiel benkiel merged commit 69393fc into robotools:v1 Dec 3, 2024
10 checks passed
@knutnergaard knutnergaard deleted the groups branch December 5, 2024 09:34
@knutnergaard knutnergaard mentioned this pull request Dec 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benkiel benkiel benkiel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knutnergaard @benkiel @typesupply