Improve consistency in BaseLib docs.
#796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add type annotation. - Add/improve documentation. - changed `BaseSegments.segments` to return `tuple` instead of `list`.
Remaining errors to be collected in robotools#775: ```zsh contour.py:58: error: Signature of "_reprContents" incompatible with supertype "BaseObject" [override] contour.py:58: note: Superclass: contour.py:58: note: @classmethod contour.py:58: note: def _reprContents(cls) -> List[str] contour.py:58: note: Subclass: contour.py:58: note: def _reprContents(self) -> List[str] contour.py:125: error: Incompatible types in assignment (expression has type "Callable[[], Any]", variable has type "Optional[BaseGlyph]") [assignment] contour.py:125: error: Argument 1 to "reference" has incompatible type "BaseGlyph"; expected "Callable[[], Any]" [arg-type] contour.py:277: error: "BaseContour" has no attribute "_getIdentifierforPoint"; maybe "_getIdentifierForPoint" or "getIdentifierForPoint"? [attr-defined] contour.py:477: error: Signature of "isCompatible" incompatible with supertype "InterpolationMixin" [override] contour.py:477: note: Superclass: contour.py:477: note: def isCompatible(self, other: Any, cls: Type[Any]) -> Tuple[bool, Any] contour.py:477: note: Subclass: contour.py:477: note: def isCompatible(self, other: BaseContour) -> Tuple[bool, str] contour.py:532: error: "str" has no attribute "fatal" [attr-defined] contour.py:532: error: "str" has no attribute "warning" [attr-defined] contour.py:533: error: "str" has no attribute "fatal" [attr-defined] contour.py:535: error: "str" has no attribute "warning" [attr-defined] contour.py:657: error: "BaseContour" has no attribute "_reverseContour" [attr-defined] ```
Changes in normalizers.py include: - Handle normalization of specific plistlib-compatible types in `normalizeLibValue`. - Resolve `mypy` errors. - Improve error messages and efficiency in certain functions.
benkiel
approved these changes
Dec 1, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.