Merge pull request #46 from MuhammadEssam96/master

Downgrade http_parser dep to 4.0.2
rodion-m · Dec 2, 2024 · 01d7d2f · 01d7d2f
2 parents 5eacc6f + 63b1d3d
commit 01d7d2f
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 9 deletions.
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -3,13 +3,7 @@ linter:
   rules:
     public_member_api_docs: false
 
-analyzer:
-  plugins:
-    - dart_code_metrics
-
 dart_code_metrics:
-  anti-patterns:
-    - long-method
   metrics:
     cyclomatic-complexity: 20
     maximum-nesting-level: 5
@@ -24,7 +18,6 @@ dart_code_metrics:
     - no-equal-arguments:
         severity: warning
     - avoid-unused-parameters
-    - binary-expression-operand-order
     - no-object-declaration
     - prefer-trailing-comma:
         exclude:

diff --git a/lib/src/default_retry_evaluator.dart b/lib/src/default_retry_evaluator.dart
@@ -10,7 +10,6 @@ class DefaultRetryEvaluator {
 
   /// Returns true only if the response hasn't been cancelled
   ///   or got a bad status code.
-  // ignore: avoid-unused-parameters
   FutureOr<bool> evaluate(DioException error, int attempt) {
     bool shouldRetry;
     if (error.type == DioExceptionType.badResponse) {

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -11,7 +11,7 @@ environment:
 
 dependencies:
   dio: ^5.7.0
-  http_parser: ^4.1.0
+  http_parser: ^4.0.2
   path: ^1.9.0
 
 dev_dependencies:

diff --git a/test/disable_retry_test.dart b/test/disable_retry_test.dart
@@ -1,4 +1,6 @@
 @TestOn('vm')
+library;
+
 import 'package:dio/dio.dart';
 import 'package:dio_smart_retry/dio_smart_retry.dart';
 import 'package:test/test.dart';

diff --git a/test/multipart_retry_tests.dart b/test/multipart_retry_tests.dart
@@ -1,4 +1,6 @@
 @TestOn('vm')
+library;
+
 import 'package:dio/dio.dart';
 import 'package:dio_smart_retry/dio_smart_retry.dart';
 import 'package:test/test.dart';

diff --git a/test/override_retryable_statuses_test.dart b/test/override_retryable_statuses_test.dart
@@ -1,4 +1,6 @@
 @TestOn('vm')
+library;
+
 import 'package:dio/dio.dart';
 import 'package:dio_smart_retry/dio_smart_retry.dart';
 import 'package:test/test.dart';

diff --git a/test/test_issue_2.dart b/test/test_issue_2.dart
@@ -1,5 +1,7 @@
 // https://github.com/rodion-m/dio_smart_retry/issues/2
 @TestOn('vm')
+library;
+
 
 import 'package:dio/dio.dart';
 import 'package:dio_smart_retry/dio_smart_retry.dart';