Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SceneGraph Node files reorganization #86

Merged
merged 8 commits into from
Jan 20, 2025
Merged

SceneGraph Node files reorganization #86

merged 8 commits into from
Jan 20, 2025

Conversation

lvcabral
Copy link
Collaborator

@lvcabral lvcabral commented Jan 20, 2025 •
edited
Loading

  • Organized the Node components in a separate folder
  • Renamed ComponentFactory to NodeFactory
  • Renamed the roTimespan component file to match the standard
  • Renamed coercion.ts to Coercion.ts
  • Updated documentation and unit tests

@lvcabral lvcabral changed the title SceneGraph files reorg SceneGraph Node files reorganization Jan 20, 2025
TwitchBronBron
TwitchBronBron approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these changes!

@lvcabral lvcabral merged commit a1b343e into master Jan 20, 2025
5 checks passed
@lvcabral lvcabral deleted the scenegraph-files-reorg branch January 20, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

@georgejecook georgejecook Awaiting requested review from georgejecook

@chrisdp chrisdp Awaiting requested review from chrisdp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lvcabral @TwitchBronBron