Add $contents virtual variable to roRegistrySection #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdp
approved these changes
Feb 21, 2025
TwitchBronBron
changed the title
TwitchBronBron
approved these changes
Feb 21, 2025
| @@ -12,4 +12,13 @@ export function pushIfRegistrySectionVariables(adapter: DebugProtocolAdapter, ex | |||
| value: VariableType.List, | |||
| children: [] | |||
| }); | |||
|
|
|||
| pushCustomVariableToContainer(adapter, container, { | |||
| name: '$contents', | |||
There was a problem hiding this comment.
I still feel like we could find a "better" name than $contents, but I can't think of anything better. It's easy enough to change this in the future, so no need to hold up the PR. @chrisdp if you're good with this, feel free to merge.
There was a problem hiding this comment.
@TwitchBronBron definitely agree, I cropped up these names if anything stands out.
- registryValues
- keyData
- sectionContent
- sectionData
- regSectionData
- sectionListData
- sectionListContent
- keyContents
- keyListContent
- keyItemValues
- sectionItems
There was a problem hiding this comment.
I think we ship it and change it later like you said. It's not unclear with the current name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a new virtual variable callled
$contentsto read registry values from roRegistrySection in the variables panel