Fix crash in bsc project when thread has error #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix-bsc-project-crash
…into fix-bsc-project-crash
TwitchBronBron
commented
Mar 4, 2025
| public async activate(options: Parameters<ProgramBuilder['run']>[0]) { | ||
| const timeEnd = this.logger.timeStart('log', 'activate'); | ||
|
|
||
| // start a new worker thread or get an unused existing thread | ||
| this.worker = bscProjectWorkerPool.getWorker(); | ||
|
|
||
| //!!!IMPORTANT!!! this observer must be registered in order to prevent the worker thread from crashing the main thread | ||
| this.worker.on('error', (error) => { |
There was a problem hiding this comment.
This was the most important part of the fix. by not observing this, node sees an unhandled exception and crashes.
TwitchBronBron
commented
Mar 4, 2025
| this.logger.error('Worker encountered an error', error); | ||
| this.errorDeferred.reject(error); | ||
| //!!!IMPORTANT!!! this is required to prevent node from freaking out about an uncaught promise | ||
| this.errorDeferred.promise.catch(e => { |
There was a problem hiding this comment.
This is also important. It's new code that helps track whether our worker has crashed. but by not observing the rejection, that would also bring down the node process. So we observe it, do nothing, and assume someone else will pay attention on the outside.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gracefully recover whenever the bsc project worker thread crashes (instead of bringing down the entire process...).
The fix was to observer the
.on('error'event from the worker thread. But then also, when we reject a deferred, if nobody is listening then that will also crash node so we need to immediately observer the rejection and ignore the error.