[Feat][SDK-347] ANR report #323
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (isMainThreadNotHandlerTicker()) { | ||
| if (isProcessNotResponding() && reported.compareAndSet(false, true)) { | ||
| if (anrListener != null) { |
There was a problem hiding this comment.
Are there any benefits to allowing the watchdog to run if no anrListener was set?
| package com.rollbar.android.anr.historical.stacktrace; | ||
|
|
||
| public final class Line { | ||
| public int lineno; |
There was a problem hiding this comment.
Sounds like something that should be read-only and hidden?
|
|
||
| public List<StackFrame> getStackFrames( | ||
| final StackTraceElement[] elements, final boolean includeFrames) { | ||
| List<StackFrame> StackFrames = null; |
There was a problem hiding this comment.
Make sure to stick to a single style convention, preferable something that's already in place.
| if (className == null || className.isEmpty()) { | ||
| return true; | ||
| } | ||
| /* |
There was a problem hiding this comment.
Let's not ship code that's commented out.
| } | ||
|
|
||
|
|
||
| public List<RollbarThread> parse(final Lines lines) { |
There was a problem hiding this comment.
Please cover with tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related issues
Checklists
Development
Code review