Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove native-agent code #324

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions .palantir/revapi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,44 @@ acceptedBreaks:
- code: "java.method.addedToInterface"
new: "method int com.rollbar.notifier.config.CommonConfig::maximumTelemetryData()"
justification: "This is going to be added in a major version"
"2.1.0":
com.rollbar:rollbar-api:
- code: "java.method.removed"
old: "method com.rollbar.api.payload.data.body.Frame.Builder com.rollbar.api.payload.data.body.Frame.Builder::locals(java.util.Map<java.lang.String, java.lang.Object>)"
justification: "Native agent removed"
- code: "java.method.removed"
old: "method java.util.Map<java.lang.String, java.lang.Object> com.rollbar.api.payload.data.body.Frame::getLocals()"
justification: "Native agent removed"
com.rollbar:rollbar-java:
- code: "java.class.removed"
old: "class com.rollbar.jvmti.CacheFrame"
justification: "Native agent removed"
- code: "java.class.removed"
old: "class com.rollbar.jvmti.LocalVariable"
justification: "Native agent removed"
- code: "java.class.removed"
old: "class com.rollbar.jvmti.ThrowableCache"
justification: "Native agent removed"
- code: "java.method.removed"
old: "method void com.rollbar.notifier.RollbarBase<RESULT, C extends com.rollbar.notifier.config.CommonConfig>::processAppPackages(com.rollbar.notifier.config.CommonConfig)"
justification: "Native agent removed"
- code: "java.method.removed"
old: "method java.util.List<java.lang.String> com.rollbar.notifier.config.CommonConfig::appPackages()"
justification: "Native agent removed"
- code: "java.field.removed"
old: "field com.rollbar.notifier.config.ConfigBuilder.appPackages"
justification: "Native agent removed"
- code: "java.method.removed"
old: "method com.rollbar.notifier.config.ConfigBuilder com.rollbar.notifier.config.ConfigBuilder::appPackages(java.util.List<java.lang.String>)"
justification: "Native agent removed"
com.rollbar:rollbar-reactive-streams:
- code: "java.method.removed"
old: "method void com.rollbar.notifier.RollbarBase<RESULT, C extends com.rollbar.notifier.config.CommonConfig>::processAppPackages(com.rollbar.notifier.config.CommonConfig) @ com.rollbar.reactivestreams.notifier.Rollbar"
justification: "Native agent removed"
- code: "java.method.removed"
old: "method com.rollbar.reactivestreams.notifier.config.ConfigBuilder com.rollbar.reactivestreams.notifier.config.ConfigBuilder::appPackages(java.util.List<java.lang.String>)"
justification: "Native agent removed"
com.rollbar:rollbar-reactive-streams-reactor:
- code: "java.method.removed"
old: "method void com.rollbar.notifier.RollbarBase<RESULT, C extends com.rollbar.notifier.config.CommonConfig>::processAppPackages(com.rollbar.notifier.config.CommonConfig) @ com.rollbar.reactivestreams.notifier.ReactorRollbar"
justification: "Native agent removed"
8 changes: 0 additions & 8 deletions examples/rollbar-java/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,6 @@ application {
mainClassName = "com.rollbar.example.Application"
}

// Uncomment the block below to use the native agent to add local variables to stack traces
// This assumes you have run `cargo build --release` inside the native-agent directory
/*
applicationDefaultJvmArgs = [
"-agentpath:../../native-agent/target/release/"+System.mapLibraryName("rollbar_java_agent"),
]
*/

dependencies {
implementation project(":rollbar-java")

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,11 @@
import com.rollbar.notifier.config.Config;
import com.rollbar.notifier.config.ConfigBuilder;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.concurrent.Callable;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.TimeUnit;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand All @@ -30,11 +29,9 @@ public class Application {
public Application() {
this.greeting = new Greeting();
LOGGER.info("Configuring Rollbar");
List<String> appPackages = Arrays.asList("com.rollbar.example");
Config config = ConfigBuilder.withAccessToken(System.getenv("ROLLBAR_ACCESSTOKEN"))
.environment("development")
.codeVersion("1.0.0")
.appPackages(appPackages)
.build();
LOGGER.info("Initializing Rollbar");
this.rollbar = Rollbar.init(config);
Expand Down
8 changes: 0 additions & 8 deletions examples/rollbar-scala/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,6 @@ application {
mainClassName = "com.rollbar.example.Application"
}

// Uncomment the block below to use the native agent to add local variables to stack traces
// This assumes you have run `cargo build --release` inside the native-agent directory
/*
applicationDefaultJvmArgs = [
"-agentpath:../../native-agent/target/release/"+System.mapLibraryName("rollbar_java_agent")
]
*/

dependencies {
implementation project(":rollbar-java")

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,46 +3,34 @@ package com.rollbar.example
import com.rollbar.notifier.Rollbar
import com.rollbar.notifier.config.ConfigBuilder

import scala.collection.JavaConverters._
import scala.util.control.NonFatal

object Application {

def main(args: Array[String]) {
val appPackages = List("com.rollbar.example")
val config = ConfigBuilder.withAccessToken(sys.env("ROLLBAR_ACCESSTOKEN"))
.language("scala")
.codeVersion("1.0.0")
.environment("development")
.appPackages(appPackages.asJava)
.build();

val rollbar = new Rollbar(config)
val rollbar = Rollbar.init(config)

val whoa = 92
try {
exec()
} catch {
case NonFatal(e) => rollbar.error(e)
}

try {
rollbar.close(true);
} catch {
case NonFatal(e) => e.printStackTrace
}
}

def exec() {
val x = 42
val y = x + 99
greeting()

throw new RuntimeException("Execution error after greeting.")
}

def greeting() {
val zz = s"Hello Rollbar!"
println(zz)
println(s"Hello Rollbar!")
}
}
Loading