Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node-resolve): add ignoreSideEffectsForRoot to exported interface #1841

Merged
merged 2 commits into from
Mar 11, 2025
Merged

fix(node-resolve): add ignoreSideEffectsForRoot to exported interface #1841

merged 2 commits into from
Mar 11, 2025

Conversation

younggglcy
Copy link
Contributor

@younggglcy younggglcy commented Feb 1, 2025 •
edited
Loading

Rollup Plugin Name: @rollup/plugin-node-resolve

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

fix #1824

Description

This PR supplies definitions of ignoreSideEffectsForRoot to the exported interface RollupNodeResolveOptions

shellscape
shellscape requested changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@shellscape shellscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please add an appropriate test of this change to packages/node-resolve/test/types.ts

@younggglcy
Copy link
Contributor Author

Thanks for the PR. Please add an appropriate test of this change to packages/node-resolve/test/types.ts

done

@shellscape shellscape merged commit d455fff into rollup:master Mar 11, 2025
15 checks passed
@younggglcy younggglcy deleted the fix/1824 branch March 12, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shellscape shellscape shellscape approved these changes

@tjenkinson tjenkinson Awaiting requested review from tjenkinson tjenkinson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@rollup/plugin-node-resolve] RollupNodeResolveOptions interface doesn't include ignoreSideEffectsForRoot
2 participants
@younggglcy @shellscape