[Bitcoin] Implement brc20 progress #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
baichuan3
reviewed
Dec 2, 2023
|
|
||
| friend rooch_framework::genesis; | ||
|
|
||
| //TODO should we register the BRC20 as a CoinInfo? |
There was a problem hiding this comment.
In the Indexer extension, specific types of Objects can be parsed, including CoinInfo and CoinStore. At the same time, by linking the Account, we can get the Coin-dimensional Indexer.
If Bitcoin and Ethereum can reuse CoinInfo, a full-chain Coin Indexer can be generated.
The generation of NFT Indexers may be more complicated.
baichuan3
reviewed
Dec 2, 2023
|
|
||
| fun progress_op(brc20_store: &mut BRC20Store, op: Op) { | ||
| if(!is_brc20(&op)){ | ||
| std::debug::print(&string::utf8(b"not brc20 op")); |
There was a problem hiding this comment.
debug info can be removed
There was a problem hiding this comment.
This part still needs to be finished; Print debug just to watch the log. Maybe I should use Event in the future.
baichuan3
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
json::from_json_optionandjson::to_mapdo not abort when invalid json.part of #993 #997
TODO: