Update the Move library to the latest version from the upstream. #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenlaw123
requested review from
jolestar,
baichuan3,
wow-sven and
pause125
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
stevenlaw123
changed the title
jolestar
reviewed
Dec 12, 2023
| @@ -2,7 +2,7 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| use clap::Parser; | |||
| use clap::__macro_refs::once_cell::sync::Lazy; | |||
| use clap::__derive_refs::once_cell::sync::Lazy; | |||
There was a problem hiding this comment.
Should it be use once_cell::sync::Lazy?
There was a problem hiding this comment.
Deal with this later.
Comment on lines
+79
to
+90
| .transpose(); | ||
|
|
||
| match result { | ||
| Ok(opt) => { | ||
| if let Some(data) = opt { | ||
| Ok((Some(data), 0)) | ||
| } else { | ||
| Ok((None, 0)) | ||
| } | ||
| } | ||
| Err(err) => Err(err), | ||
| } |
There was a problem hiding this comment.
Deal with this later.
| @@ -345,7 +346,9 @@ impl<'a> ExtendedChecker<'a> { | |||
| impl<'a> ExtendedChecker<'a> { | |||
| fn check_init_module(&mut self, module: &ModuleEnv) { | |||
| for ref fun in module.get_functions() { | |||
| if fun.get_identifier().as_ident_str() != INIT_FN_NAME_IDENTIFIER.as_ident_str() { | |||
| if fun.get_identifier().unwrap().as_ident_str() | |||
There was a problem hiding this comment.
Be careful unwrap; if it occurs in runtime, it will be a security bug.
| } | ||
| } | ||
|
|
||
| impl<R> ModuleResolver for MoveOSResolverProxy<R> | ||
| where | ||
| R: StateResolver, | ||
| { | ||
| type Error = anyhow::Error; | ||
| fn get_module_metadata(&self, _module_id: &ModuleId) -> Vec<Metadata> { | ||
| vec![] |
There was a problem hiding this comment.
Just return an empty array? Do we use the get_module_metadata in the VM?
There was a problem hiding this comment.
Currently, the metadata for the module is manually read from the VM and the function is not invoked.
added 2 commits
December 12, 2023 18:29
jolestar
approved these changes
Dec 12, 2023
jolestar
requested changes
Dec 12, 2023
| @@ -362,6 +362,41 @@ impl FromStr for FunctionArg { | |||
| } | |||
| } | |||
|
|
|||
| pub fn parse_function_arg(s: &str) -> Result<FunctionArg, RoochError> { | |||
There was a problem hiding this comment.
Why not directly use from_str?
Comment on lines
+35
to
+36
| let s = value.as_str().unwrap(); | ||
| let ret = serde_json::from_str(s); |
There was a problem hiding this comment.
Which change affects the RPC response?
| @@ -102,7 +102,7 @@ module moveos_std::type_info { | |||
| //assert!(type_name<TypeInfo>() == string::utf8(b"0x1::type_info::TypeInfo"), 9); | |||
| assert!(type_name<TypeInfo>() == string::utf8(b"0000000000000000000000000000000000000000000000000000000000000002::type_info::TypeInfo"), 9); | |||
|
|
|||
| assert!(type_name<TestMultiGenerics<u8, u64, vector<u8>>>() == string::utf8(b"0000000000000000000000000000000000000000000000000000000000000002::type_info::TestMultiGenerics<u8,u64,vector<u8>>"), 10); | |||
| assert!(type_name<TestMultiGenerics<u8, u64, vector<u8>>>() == string::utf8(b"0000000000000000000000000000000000000000000000000000000000000002::type_info::TestMultiGenerics<u8u64vector<u8>>"), 10); | |||
There was a problem hiding this comment.
Which change affects this? The original format is right.
| @@ -150,7 +150,7 @@ Feature: Rooch CLI integration tests | |||
| Given a server for kv_store | |||
| Then cmd: "move publish -p ../../examples/kv_store --named-addresses rooch_examples=default" | |||
| Then assert: "{{$.move[-1].execution_info.status.type}} == executed" | |||
| Then cmd: "move run --function default::kv_store::add_value --args string:key1 string:value1" | |||
| Then cmd: "move run --function default::kv_store::add_value --args string:key1 --args string:value1" | |||
There was a problem hiding this comment.
Do we not support splitting the args with blank?
jolestar
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.