Framework upgrade #1229
Merged
Framework upgrade #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
pause125
force-pushed
the
framework-upgrade1
branch
from
3b7cb75 to
c10f128
Compare
pause125
force-pushed
the
framework-upgrade1
branch
from
c10f128 to
83bcda2
Compare
pause125
requested review from
jolestar,
baichuan3 and
wow-sven
as code owners
jolestar
approved these changes
Dec 21, 2023
| entry fun upgrade_entry(ctx: &mut Context, account: &signer, | ||
| move_std_bundles: vector<vector<u8>>, | ||
| moveos_std_bundles: vector<vector<u8>>, | ||
| rooch_framework_bundles: vector<vector<u8>>, |
There was a problem hiding this comment.
Also need the bitcoin_move_bundles
baichuan3
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
onchain_configmodule and store sequencer address onchain when genesis init.account_storage::publish_modulesfor gas saving.How to test
cargo run --package rooch-framework-release --bin rooch-framework-release -- -v 1to build framework and save package to disk. Package binary will be saved at path:crates/rooch-framework-release/compiled/1/rooch move framework -p crates/rooch-framework-release/compiled/1/stdlibto publish framework binary. If not sequencer account, the txn will fail. This command will submit txn to callrooch_framework::upgrade::upgrade_entryfunction.TODO
Version management. Currently, a
framework_versionnumber is recorded onchain, every invokingrooch_framework::upgrade::upgrade_entrywill increment this number, ignoring the version set in commandcargo run --package rooch-framework-release --bin rooch-framework-release -- -v <version_number>Find an appropriate way to test framework upgrades in CI.
Closes [Framework] Framework upgrade #1219