Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bitcoin] bitseed validity #1581

Merged
merged 18 commits into from
May 17, 2024
Merged

[Bitcoin] bitseed validity #1581

merged 18 commits into from
May 17, 2024

Conversation

yubing744
Copy link
Collaborator

Summary

Summary about this PR

  • Closes #issue

@vercel Vercel
Copy link

vercel bot commented Apr 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch-rooch-portal-v1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 6:41am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rooch ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 6:41am

@yubing744 yubing744 force-pushed the owen/bitseed/index-sft branch from bf647a1 to f3a4ce3 Compare April 18, 2024 14:36
@yubing744 yubing744 changed the title feat: index utxo and inscription ok [Bitcoin] bitseed validity Apr 26, 2024
@yubing744 yubing744 force-pushed the owen/bitseed/index-sft branch from 29ab79c to 62f18d3 Compare April 27, 2024 02:27
@yubing744 yubing744 force-pushed the owen/bitseed/index-sft branch from 081a66d to a02dae7 Compare May 6, 2024 14:21
@yubing744 yubing744 force-pushed the owen/bitseed/index-sft branch from 2215a78 to 70dcc2b Compare May 17, 2024 00:08
@yubing744
Copy link
Collaborator Author

yubing744 commented May 17, 2024 •
edited
Loading

image

After rebasing the main branch, compiling frameworks reports an error with no useful error message

@jolestar Please help me look at this problem. Use the following command to trigger

bash ./scripts/bitcoin/test.sh -u

@yubing744 yubing744 marked this pull request as ready for review May 17, 2024 01:17
jolestar
jolestar approved these changes May 17, 2024
View reviewed changes
frameworks/bitcoin-move/sources/ord.move
/// Returns true if Inscription `object` contains metaprotocol validity
public fun exists_metaprotocol_validity(inscription_id: InscriptionID): bool{
let store_obj_id = object::named_object_id<InscriptionStore>();
let store_obj = object::borrow_mut_object_shared<InscriptionStore>(store_obj_id);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not need to borrow_mut.

frameworks/bitcoin-move/sources/ord.move
Comment on lines +959 to +965
let inscription_object_id = derive_inscription_id(inscription_id);
let exists = object::contains_object_field<InscriptionStore, Inscription>(store_obj, inscription_object_id);
if (!exists) {
return false
};

let inscription_obj = object::borrow_mut_object_field<InscriptionStore, Inscription>(store_obj, inscription_object_id);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provide a function borrow_inscription_option(InscriptionID):Option<Inscription> ?

crates/testsuite/tests/images/bitseed.rs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can migrate the bitseed command to rooch bitseed in the future.

@jolestar jolestar force-pushed the owen/bitseed/index-sft branch from 3900a75 to 217b1a6 Compare May 17, 2024 04:37
@jolestar
Copy link
Contributor

image

After rebasing the main branch, compiling frameworks reports an error with no useful error message

@jolestar Please help me look at this problem. Use the following command to trigger

bash ./scripts/bitcoin/test.sh -u

Because the ord.move and bitcoin.move contains break change.

@jolestar jolestar requested a review from steelgeek091 as a code owner May 17, 2024 05:39
@jolestar
Copy link
Contributor

@steelgeek091 I change the verifier, allow std::string::String and std::ascii::String as data_struct.

@jolestar
Copy link
Contributor

'bitseed/bitseed:0.1.4' needs to be pulled before testing.

I merge this PR first.

@jolestar jolestar merged commit 18693e3 into rooch-network:main May 17, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolestar jolestar jolestar approved these changes

@steelgeek091 steelgeek091 steelgeek091 approved these changes

@wow-sven wow-sven Awaiting requested review from wow-sven wow-sven is a code owner

@geometryolife geometryolife Awaiting requested review from geometryolife geometryolife is a code owner

@pause125 pause125 Awaiting requested review from pause125 pause125 is a code owner

@baichuan3 baichuan3 Awaiting requested review from baichuan3 baichuan3 is a code owner

@yourmoonlight yourmoonlight Awaiting requested review from yourmoonlight yourmoonlight is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yubing744 @jolestar @steelgeek091