Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci workflow #1866

Closed
wants to merge 7 commits into from
Closed

Ci workflow #1866

wants to merge 7 commits into from

Conversation

yourmoonlight
Copy link
Collaborator

Summary

Summary about this PR

  1. clean unused workflows
  2. use dtolnay/rust-toolchain instead of actions-rs/toolchain, cause it's unmaintained
  3. Using relative path to reference the action in the current branch for rust-setup

@yourmoonlight yourmoonlight requested a review from wow-sven June 11, 2024 13:21
@yourmoonlight yourmoonlight requested a review from jolestar as a code owner June 11, 2024 13:21
Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 2:46pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rooch ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 2:46pm

Copy link

github-actions bot commented Jun 11, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
actions/rooch-network/rooch/.github/actions/rust-setup main UnknownUnknown

Scanned Manifest Files

.github/workflows/check_build_test.yml
  • rooch-network/rooch/.github/actions/rust-setup@main

@yourmoonlight yourmoonlight marked this pull request as draft June 11, 2024 13:28
@yourmoonlight yourmoonlight marked this pull request as ready for review June 11, 2024 13:45
@yourmoonlight yourmoonlight marked this pull request as draft June 11, 2024 13:48
rust-toolchain.toml Outdated Show resolved Hide resolved
with:
override: true
components: rustfmt, clippy
- uses: dtolnay/rust-toolchain@1.77.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为啥不用 actions-rs/toolchain 这个了?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为啥不用 actions-rs/toolchain 这个了?

cause it's unmaintained, dtolnay/rust-toolchain may be a better choice?

@yourmoonlight
Copy link
Collaborator Author

close, completed through other prs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[devops] Upgrade the actions-rs/toolchain and remove the rust-toolchain file
2 participants