[framework] Framework review and do some refactor #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
baichuan3
reviewed
Jun 14, 2024
| @@ -136,14 +132,14 @@ module moveos_std::wasm { | |||
|
|
|||
| // 1. Create WASM VM instance (required step) | |||
| let wasm_instance = create_wasm_instance(wasm_code); | |||
| debug::print(&string::utf8(b"wasm_instance:")); | |||
| debug::print(&wasm_instance); | |||
| // std::debug::print(&std::string::utf8(b"wasm_instance:")); | |||
There was a problem hiding this comment.
在测试用例里，debug还有用，先注释掉吧
baichuan3
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
address::from_ascii_stringand replace withaddress::from_ascii_bytes.bitcoin_hash::from_ascii_bytesfor bitcoin reversed hex.cc @yubing744 and @vegetabledogdog
part of #1683