Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[framework] OnChainEvent, Metaprotocol, Bitseed #2197

Merged
merged 24 commits into from
Aug 2, 2024
Merged

[framework] OnChainEvent, Metaprotocol, Bitseed #2197

merged 24 commits into from
Aug 2, 2024

Conversation

jolestar
Copy link
Contributor

@jolestar jolestar commented Jul 16, 2024 •
edited
Loading

Summary

  1. [moveos_std] Implement on-chain event queue, resolve [moveos_std] General OnChain EventQueue #2196
  2. [moveos_std] Implement result type for error handle.
  3. [moveos_std] Add copy, drop to SimpleMap.
  4. [bitcoin-move] Define InscriptionEvent in ord and emit events to the on-chain event queue.
  5. [bitcoin-move] Implement MetaprotocolRegistry and require the metaprotocol_validity type to be registered.
  6. [bitseed] Define Bitseed in Move and implement Bitseed TickInfo, MintGetFactory.

TODO:

  1. Implement Bitseed merge and split via Inscription.
  2. Handle the attributes in Bitseed.
  3. Handle the repeat in Bitseed.
  4. Handle the factory and factory argument in Bitseed.
  5. Implement leap.

@vercel Vercel
Copy link

vercel bot commented Jul 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 6:09am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rooch ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2024 6:09am

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 16, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@jolestar jolestar force-pushed the onchain_event_queue branch from 2327c51 to 633efbb Compare July 17, 2024 16:26
@jolestar jolestar force-pushed the onchain_event_queue branch from 8a16bd5 to be4920c Compare July 22, 2024 14:43
@jolestar jolestar force-pushed the onchain_event_queue branch from be4920c to b589433 Compare July 30, 2024 08:33
@jolestar jolestar changed the title [framework] A draft implemention of OnChainEvent [framework] OnChainEvent, Metaprotocol, Bitseed Jul 30, 2024
@jolestar jolestar marked this pull request as ready for review July 30, 2024 08:55
@jolestar
Copy link
Contributor Author

jolestar commented Jul 30, 2024 •
edited
Loading

This big PR is ready; help review it. @yubing744 @baichuan3 @pause125 @mx819812523

https://discord.com/channels/1078938449974935592/1267769544798244935

yubing744
yubing744 reviewed Jul 30, 2024
View reviewed changes
frameworks/moveos-stdlib/sources/event_queue.move
//It means the subscriber is too slow to consume the event
//We should update the subscriber sequence number to the tail sequence number
subscriber_sequence_number = if (tail_sequence_number > subscriber_sequence_number) {
tail_sequence_number
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that it is not appropriate to jump directly to the end of the queue here, which may cause inconsistent data on the consumer side. It feels better to return an error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the subscriber handle the error?

@jolestar jolestar requested a review from steelgeek091 as a code owner July 31, 2024 10:25
@jolestar jolestar force-pushed the onchain_event_queue branch from d3c4e38 to f4da7ce Compare July 31, 2024 14:53
@jolestar jolestar force-pushed the onchain_event_queue branch from f4da7ce to 263d203 Compare August 1, 2024 04:03
@jolestar jolestar requested a review from yourmoonlight as a code owner August 1, 2024 06:08
@jolestar jolestar mentioned this pull request Aug 1, 2024
Open
7 tasks
@jolestar
Copy link
Contributor Author

jolestar commented Aug 1, 2024

@pause125 @yubing744

@jolestar jolestar merged commit ca49b26 into main Aug 2, 2024
8 checks passed
@jolestar jolestar deleted the onchain_event_queue branch August 2, 2024 01:35
@jolestar jolestar mentioned this pull request Aug 2, 2024
Merged
@jolestar jolestar mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yubing744 yubing744 yubing744 left review comments

@pause125 pause125 pause125 approved these changes

@mx819812523 mx819812523 Awaiting requested review from mx819812523

@wow-sven wow-sven Awaiting requested review from wow-sven wow-sven is a code owner

@geometryolife geometryolife Awaiting requested review from geometryolife geometryolife is a code owner

@baichuan3 baichuan3 Awaiting requested review from baichuan3 baichuan3 is a code owner

@steelgeek091 steelgeek091 Awaiting requested review from steelgeek091 steelgeek091 is a code owner

@yourmoonlight yourmoonlight Awaiting requested review from yourmoonlight yourmoonlight is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[moveos_std] General OnChain EventQueue
3 participants
@jolestar @yubing744 @pause125