refactor(genesis_ord): remove 'is_p2pk' field and related logic #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 18, 2024 07:46
address has been derived in inscription source for p2pk script: The 'is_p2pk' field and corresponding logic in genesis_ord.rs have been removed. This change simplifies the solution and doesn't affect the functionality, as 'address' is directly converted into 'bitcoin_address' using BitcoinAddress::from_str method now.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
popcnt1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
address has been derived in inscription source for p2pk script:
The 'is_p2pk' field and corresponding logic in genesis_ord.rs have been removed. This change simplifies the solution and doesn't affect the functionality, as 'address' is directly converted into 'bitcoin_address' using BitcoinAddress::from_str method now.