feat: support list fields for object.move #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lispking
requested review from
jolestar,
baichuan3,
wow-sven and
steelgeek091
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
lispking
changed the title
|
@jolestar is attempting to deploy a commit to the Rooch Team on Vercel. A member of the Team first needs to authorize it. |
jolestar
reviewed
Jan 2, 2025
frameworks/moveos-stdlib/src/natives/moveos_stdlib/object/object_field_fn.rs
Outdated
Show resolved
Hide resolved
lispking
changed the title
jolestar
reviewed
Jan 3, 2025
steelgeek091
requested changes
Jan 3, 2025
frameworks/moveos-stdlib/src/natives/moveos_stdlib/object/object_field_fn.rs
Outdated
Show resolved
Hide resolved
jolestar
reviewed
Jan 3, 2025
steelgeek091
reviewed
Jan 3, 2025
frameworks/rooch-framework/src/natives/gas_parameter/object_list_field_keys.rs
Outdated
Show resolved
Hide resolved
steelgeek091
approved these changes
Jan 3, 2025
jolestar
reviewed
Jan 4, 2025
There was a problem hiding this comment.
需要构造一个测试用例：
第一个交易写 fields，第二个交易写并且读 fields。
测试目标：
- 测试从 db 中加载的场景。
- 测试如果 RuntimeObject 的 fields 中混合了 fresh 和 cached fields 后的翻页。
- 同一个交易中，数据有变化的情况下，多次遍历的结果是否一致。
这种测试需要通过集成测试来实现，参看 https://github.com/rooch-network/rooch/blob/be131eef2bb313c19d45c84ac5832ba96fbdbb69/crates/rooch-framework-tests/tests/cases
jolestar
reviewed
Jan 4, 2025
crates/rooch-framework-tests/tests/cases/table/list_field_keys.move
Outdated
Show resolved
Hide resolved
jolestar
reviewed
Jan 4, 2025
jolestar
approved these changes
Jan 5, 2025
jolestar
added a commit
that referenced
this pull request
Jan 8, 2025
* feat: support list fields for object.move * fix UNKNOWN_INVARIANT_VIOLATION_ERROR * rename list_fields to list_field_names * fix native return types * make code tidy * make code tidy * make code tidy * support cursor and limit for list_field_keys * update object list_field_keys gas handle and adjust fetch data from db * make code tidy * update native_list_field_keys default value to 0 * check is_empty that before add native_list_field_keys * update is_empty for ListFieldsGasParametersOption * fix review notes * fix lint * add list_field_keys for table and add rooch-framework-tests * update ut assert value * update list_field_keys of table notes * add length ut for list_field_keys * add more ut for list_field_keys * make ut tidy * add iterator for table * fix next/next_mut for table issue * update borrow_field_key_internal and borrow_mut_field_key_internal notes * add How to test move contract? notes * update borrow_field_key_internal and borrow_mut_field_key_internal notes * update review notes * update review notes --------- Co-authored-by: jolestar <jolestar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.