[RF] Make it clear when to use RooSimultaneous::generateSimGlobal #17638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9c044b4.
More details in the comments in the code added in this commit. To make it short: the user probably wants to use `generateSimGlobal` when not generating the index category value (or taking it from a proto dataset), and `RooAbsPdf::generate()` otherwise. To avoid confusion, there are now new errors when one does the opposite, which is certainly a user error.
Test Results 18 files 18 suites 4d 11h 23m 17s ⏱️ For more details on these failures, see this check. Results for commit 4b0ba94. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details in the comments in the code added in this commit.
To make it short: the user probably wants to use
generateSimGlobalwhen not generating the index category value (or taking it from a proto
dataset), and
RooAbsPdf::generate()otherwise.To avoid confusion, there are now new errors when one does the opposite,
which is certainly a user error.
Revert also the commit where I deprecated
generateSimGlobalfor a lack of a real understanding of its purpose.Thanks to @TomasDado for pointing out that it's still needed, and for privately providing a code example where it's necessary.