[RF][HF] Re-use any type of RooAbsArgs in ParamHistFunc::createParamSet #17654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When connecting preprocessing functions to nuisance parameters via `Measurement::AddPreprocessFunction`, the nuisance parameter is replaced by a RooAbsReal that is not a RooRealVar, and the implementation of `ParamHistFunc::createParamSet` should be able to deal with that. So far, `createParamSet` assumed that any pre-existing argument in the workspace with the nuisance parameter name is of type RooRealVar, which is not valid in that case. Therefore, using preprocessing functions in place of these parameters resulted in a segfault. To fix this, the code is generalized to any RooAbsArg type. Closes root-project#12225.
Test Results 18 files 18 suites 4d 17h 55m 26s ⏱️ For more details on these failures, see this check. Results for commit aa36505. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting preprocessing functions to nuisance parameters via
Measurement::AddPreprocessFunction, the nuisance parameter is replaced by a RooAbsReal that is not a RooRealVar, and the implementation ofParamHistFunc::createParamSetshould be able to deal with that.So far,
createParamSetassumed that any pre-existing argument in the workspace with the nuisance parameter name is of type RooRealVar, which is not valid in that case. Therefore, using preprocessing functions in place of these parameters resulted in a segfault.To fix this, the code is generalized to any RooAbsArg type.
Closes #12225.