[ntuple] Move public utility types out of experimental #17665
Conversation
jblomer
requested review from
bellenot,
linev,
martamaja10 and
vepadulano
as code owners
jblomer
force-pushed
the
ntuple-move-utils
branch
from
555b382 to
a7e39d6
Compare
jblomer
force-pushed
the
ntuple-move-utils
branch
from
a7e39d6 to
cf16f85
Compare
Test Results 18 files 18 suites 3d 18h 22m 45s ⏱️ For more details on these failures, see this check. Results for commit cf16f85. ♻️ This comment has been updated with latest results. |
| class RLogChannel; | ||
| /// Log channel for RNTuple diagnostics. | ||
| ROOT::RLogChannel &NTupleLog(); | ||
|
|
There was a problem hiding this comment.
Actually, do we want this in the public interface? Would it be sufficient to be in ROOT::Internal?
| ENTupleColumnType fType; | ||
| ROOT::ENTupleColumnType fType; |
There was a problem hiding this comment.
Question here and everywhere else: Do we want to qualify the types in our own classes? I think it should not be needed due to namespace nesting, and it becomes redundant when we move other classes. Will we remove them later on?
There was a problem hiding this comment.
As discussed in the IO meeting, it's needed because otherwise it will pick up the (deprecated) using declarations in ROOT::Experimental. The approach may be to remove the deprecation message for now and only add it back once all classes are moved until we remove the using declarations before branching.
Companion PR: root-project/roottest#1258