Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iron branch #1155

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Add iron branch #1155

merged 4 commits into from
Nov 6, 2023

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Nov 4, 2023

Adding bits to support an iron branch

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2023 •
edited
Loading

Codecov Report

Merging #1155 (4577f7b) into master (5e6b676) will not change coverage.
Report is 3 commits behind head on master.
The diff coverage is n/a.

❗ Current head 4577f7b differs from pull request most recent head 0fc1d42. Consider uploading reports for the commit 0fc1d42 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1155   +/-   ##
=======================================
  Coverage   47.46%   47.46%           
=======================================
  Files          41       41           
  Lines        3451     3451           
  Branches     1874     1874           
=======================================
  Hits         1638     1638           
  Misses        486      486           
  Partials     1327     1327
Flag Coverage Δ
unittests 47.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bmagyar bmagyar changed the title Add backport-to-iron workflow Add iron branch Nov 4, 2023
christophfroehlich
christophfroehlich reviewed Nov 4, 2023
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On what distro should the dockerfiles run? the released one is still on humble?

@bmagyar @christophfroehlich
Apply suggestions from code review
0fc1d42 
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
@bmagyar bmagyar enabled auto-merge (squash) November 6, 2023 18:26
@bmagyar bmagyar disabled auto-merge November 6, 2023 18:40
@bmagyar bmagyar merged commit 6100c5c into ros-controls:master Nov 6, 2023
1 check failed
mergify bot pushed a commit that referenced this pull request Nov 6, 2023
@bmagyar @mergify
Add iron branch (#1155)
b948ae4 
(cherry picked from commit 6100c5c)
@mergify mergify bot mentioned this pull request Nov 6, 2023
Merged
bmagyar pushed a commit that referenced this pull request Nov 7, 2023
@mergify
Add iron branch (#1155) (#1158)
0bcd9fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfroehlich christophfroehlich christophfroehlich left review comments

@anfemosa anfemosa Awaiting requested review from anfemosa

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@destogl destogl Awaiting requested review from destogl

@erickisos erickisos Awaiting requested review from erickisos

@harderthan harderthan Awaiting requested review from harderthan

@mcbed mcbed Awaiting requested review from mcbed

Assignees
No one assigned
Labels
holding rolling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmagyar @christophfroehlich