Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added InsertBraces option of clang formatting and update the needed m… #1194

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

saikishor
Copy link
Member

@saikishor saikishor commented Dec 4, 2023

After the PR: #1193. I have added this new Clang-format style option to have the similar styling in future.

Once the PR : #1193 is merged, I can apply this change to all the packages and check for any missing one that are not addressed in the previous PR

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brace for impact!

@bmagyar bmagyar merged commit 6ca76cd into ros-controls:master Dec 11, 2023
12 of 13 checks passed
@saikishor saikishor deleted the update_clang_format_styling branch August 17, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants