Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove joint_state_controller #1263

Merged

Conversation

christophfroehlich
Copy link
Contributor

I found remnants from the time before joint_state_controller got renamed to joint_state_broadcaster.

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. backport-iron labels Jan 1, 2024
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (54ced2a) 47.82% compared to head (3a8d4b7) 47.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1263   +/-   ##
=======================================
  Coverage   47.82%   47.82%           
=======================================
  Files          40       40           
  Lines        3448     3448           
  Branches     1869     1869           
=======================================
  Hits         1649     1649           
  Misses        456      456           
  Partials     1343     1343           
Flag Coverage Δ
unittests 47.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it. LGTM

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

@bmagyar bmagyar merged commit e149646 into ros-controls:master Jan 3, 2024
14 checks passed
mergify bot pushed a commit that referenced this pull request Jan 3, 2024
mergify bot pushed a commit that referenced this pull request Jan 3, 2024
@christophfroehlich christophfroehlich deleted the rm_joint_state_controller branch January 3, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants