Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use target_compile_definitions instead of installing test files #2009

Merged

Conversation

saikishor
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.37%. Comparing base (d4139b7) to head (f967d58).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2009      +/-   ##
==========================================
- Coverage   89.38%   89.37%   -0.02%     
==========================================
  Files         132      132              
  Lines       14663    14649      -14     
  Branches     1258     1258              
==========================================
- Hits        13106    13092      -14     
- Misses       1090     1091       +1     
+ Partials      467      466       -1     
Flag Coverage Δ
unittests 89.37% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...er_interface/test/test_controller_with_options.cpp 100.00% <100.00%> (ø)
controller_manager/test/test_spawner_unspawner.cpp 96.62% <100.00%> (-0.11%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from removing ament_index_cpp from the deps in CMakeLists and package.xml

controller_manager/CMakeLists.txt Show resolved Hide resolved
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmagyar bmagyar merged commit fbfc01d into ros-controls:master Jan 23, 2025
25 checks passed
@bmagyar bmagyar deleted the remove/installed/test/files branch January 23, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants