-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use target_compile_definitions
instead of installing test files
#2009
Use target_compile_definitions
instead of installing test files
#2009
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2009 +/- ##
==========================================
- Coverage 89.38% 89.37% -0.02%
==========================================
Files 132 132
Lines 14663 14649 -14
Branches 1258 1258
==========================================
- Hits 13106 13092 -14
- Misses 1090 1091 +1
+ Partials 467 466 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, apart from removing ament_index_cpp from the deps in CMakeLists and package.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.